-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish snapshot to maven #400
Conversation
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
.github/workflows/maven-publish.yml
Outdated
push: | ||
branches: | ||
- 'main' | ||
- '1.*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.x do not have this task. It started from 2.x. Would recommend to remove this to avoid failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Role has been added to the secrets.
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
* Publish snapshot to maven Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Removing 1.x branch from maven publish workflow Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> (cherry picked from commit 13eda9f)
* Publish snapshot to maven Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Removing 1.x branch from maven publish workflow Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> (cherry picked from commit 13eda9f) Co-authored-by: Sagar <99425694+sgup432@users.noreply.github.com>
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#385
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.